Re: [Fastboot] [PATCH 11/20] x86_64: wakeup.S misc cleanups

From: Lombard, David N
Date: Thu Mar 08 2007 - 11:05:38 EST


On Thu, Mar 08, 2007 at 12:43:35PM +0100, Pavel Machek wrote:
> > > > + movw $0x0e00 + 'i', %ds:(0xb8012)
> > > > + movb $0xa8, %al ; outb %al, $0x80;
> > > > +
> > >
> > > > - movw $0x0e00 + 'i', %ds:(0xb8012)
> > > > - movb $0xa8, %al ; outb %al, $0x80;
> > >
> > > Outbs were my debugging hacks, perhaps you can simply remove them at
> > > this point? Not sure how useful "Linux" debug print is, it can
> > > probably be removed, too.
> > >
> > I found these debugging hacks useful while debugging some problem with
> > my changes in this code. It helps to find out till what poing code flow
> > as reached in this assembly code. So I think its not a bad idea to let
> > this piece code be there.
>
> Ok. (I was not sure how common are displays of port 0x80).

They're now typically available in reasonably well stocked stores; I picked
one up from CompUSA about a year ago...

--
David N. Lombard, Intel, Irvine, CA
I do not speak for Intel Corporation; all comments are strictly my own.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/