Re: [PATCH 16/20] swsusp: do not use virt_to_page on kernel data address

From: Vivek Goyal
Date: Thu Mar 08 2007 - 00:04:55 EST


On Wed, Mar 07, 2007 at 11:50:06PM +0100, Pavel Machek wrote:
> Hi!
>
> > o virt_to_page() call should be used on kernel linear addresses and not
> > on kernel text and data addresses. Swsusp code uses it on kernel data
> > (statically allocated swsusp_header).
> >
> > o Allocate swsusp_header dynamically so that virt_to_page() can be used
> > safely.
> >
> > o I am changing this because in next few patches, __pa() on x86_64 will
> > no longer support kernel text and data addresses and hibernation breaks.
> >
> > Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx>
>
> (I assume this was tested, too?)
> Pavel

Yes. I have tested this and it works fine.

Thanks
Vivek
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/