Re: [patch 2/8] update ctime and mtime for mmaped write

[Miklos Szeredi]

> I'm not liking this, its not a constant operation as the name implies.

OK, I'll think of something better.

> And it style is a bit out of line with the rest of rmap.
> 
> The thing it actually does is page_mkclean(), all it doesn't do is
> setting the pte read-only.
> 
> I can understand you wanting to avoid the overhead of the minor faults
> resulting from using page_mkclean(), but I'm not sure its worth it.

It would be nice if the cost of MS_ASYNC wouldn't be too high.  And I
do have the feeling that minor faults are far more expensive than
cleaning the dirty bit in the ptes.

Do you have any numbers?

Thanks,
Miklos
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/