Re: [patch 2.6.21-rc2] gpio_keys driver shouldn't be ARM-specific

From: Ben Nizette
Date: Thu Mar 01 2007 - 19:19:30 EST


David Brownell wrote:
The gpio_keys driver is wrongly ARM-specific; it can't build on
other platforms with GPIO suport. This fixes that problem.

I did up a similar patch a few days back, you beat me too it ;). I've been using this driver on AVR32 for a while now.

The other thing was that this driver only depends on the machine supporting your generic GPIO conventions. Currently the Kconfig entry for gpio_keys reads:

depends on (ARCH_SA1100 || ARCH_PXA || ARCH_S3C2410)

With the || AVR32 I've added to my version it's getting a bit out of hand! Anyone else think it would be worth introducing a GPIO_FRAMEWORK symbol selected by each machine which supports it and just set the gpio_keys dependency to that?

Ben.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/