Re: [PATCH -mm 3/7] Freezer: Remove PF_NOFREEZE from rcutorture thread

From: Anton Blanchard
Date: Thu Mar 01 2007 - 14:39:19 EST



Hi,

> Remove PF_NOFREEZE from the rcutorture thread, adding a
> try_to_freeze() call as required.

...

> @@ -607,6 +607,7 @@ rcu_torture_writer(void *arg)
> }
> rcu_torture_current_version++;
> oldbatch = cur_ops->completed();
> + try_to_freeze();
> } while (!kthread_should_stop() && !fullstop);
> VERBOSE_PRINTK_STRING("rcu_torture_writer task stopping");
> while (!kthread_should_stop())

I wonder if it makes sense to embed try_to_freeze() into the kthread
API somewhere. Short of that we should document the try_to_freeze()
requirement in the kthread documentation... Unfortunately I cant find
any kthread docs in Documentation/ :)

Anton
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/