Re: Thread flags modified without set_thread_flag() (nonatomically)

From: Haavard Skinnemoen
Date: Thu Mar 01 2007 - 05:15:25 EST


On Thu, 1 Mar 2007 01:45:23 -0800
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> If there's a lesson here, it is "don't provide #defines in the header for
> both versions".

Yes, that's true. It looks like all the other arches do the same thing
with the _TIF flags, however, so just ripping it out probably won't
work. Maybe I'll give it a try just to see how much trouble it is.

> > I don't think either of those need to be atomic though, since both of
> > them happen in monitor mode with interrupts disabled.
>
> That's true until you implement SMP ;)

True. I'm not sure what it can race against though...perhaps something
in kernel/signal.c?

Haavard
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/