Re: [PATCH] display class

[James Simmons]

> this stuff looks el-crappo in an 80-col display.

Cleaning up....

> This guy can have static scope.
> 
> It's a bit awkward having a fixed size.  I think lib/idr.c would suit for
> this.
>
> Also, we do set_bit() and clear_bit() on this, which are needlessly atomic. 
> If we hold a suitable lock then we can use __set_bit() and __clear_bit().
> 
> And we do need a suitable lock.

Fixing... Never knew about idr. Hum nice :-) I will have a new patch your 
way. I just need to do some teste first.

> Why all the ifdeffery?  I think plain old
> 
> 
> static void __exit display_class_exit(void)
> {
> 	class_destroy(display_class);
> }
> module_exit(display_class_exit);
> module_init(display_class_init);

That is from the hunting of the bug with the broken symlinks in /sys. Will 
go back to sanity.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/