Re: include/linux/xattr.h: how much userpace visible?

From: H. Peter Anvin
Date: Mon Feb 26 2007 - 19:13:55 EST


Christoph Hellwig wrote:
What's the problem of exposing all these APIs unconditionally?
glibcs should either use all information from the linux/ headers
or nothing at all, but not depend on hiding some bits.

It's not always that simple. In particular, in some files there might be typedefs or structure tags that step on libc's namespace (but are useful to other libcs), but ABI constants that are universally useful.

One way to deal with the particular issue of structure tags which is probably even more useful is:

#if defined(__KERNEL__) || defined(__KERNEL_EXPORT_STRUCTURES)
# define __kstruct_stat stat
#endif

struct __kstruct_stat {
/* ...foo... */
};

... which lets the libc export it into whatever namespace it wants by #defining __kstruct macros accordingly.

-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/