Re: [irq: Remove set_native_irq_info] !CONFIG_SMP regression

From: Eric W. Biederman
Date: Mon Feb 26 2007 - 18:51:17 EST


Simon Arlott <simon@xxxxxxxxxx> writes:

> 9f0a5ba5508143731dc63235de19659be20d26dc is first bad commit
> commit 9f0a5ba5508143731dc63235de19659be20d26dc
> Author: Eric W. Biederman <ebiederm@xxxxxxxxxxxx>
> Date: Fri Feb 23 04:13:55 2007 -0700
>
> [PATCH] irq: Remove set_native_irq_info
>
> This patch replaces all instances of "set_native_irq_info(irq, mask)"
> with "irq_desc[irq].affinity = mask". The latter form is clearer
> uses fewer abstractions, and makes access to this field uniform
> accross different architectures.
>
>
>
> arch/i386/kernel/io_apic.c: In function `setup_IO_APIC_irqs':
> arch/i386/kernel/io_apic.c:1357: error: structure has no member named `affinity'
> arch/i386/kernel/io_apic.c: In function `io_apic_set_pci_routing':
> arch/i386/kernel/io_apic.c:2878: error: structure has no member named `affinity'
>
>
> The original version was an empty function if !CONFIG_SMP, struct irq_desc only
> has 'affinity' on SMP.

Yep.

Give me a bit. I think we can just kill those lines.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/