Re: [PATCH] Remove redundant #ifdef __KERNEL__ checks.

From: Robert P. J. Day
Date: Mon Feb 26 2007 - 16:19:57 EST


On Mon, 26 Feb 2007, H. Peter Anvin wrote:

> Robert P. J. Day wrote:
> > On Sun, 25 Feb 2007, H. Peter Anvin wrote:
> >
> > > Robert P. J. Day wrote:
> > > > Remove the redundant intermediate checks for __KERNEL__ since, as
> > > > soon as one ends, the next one starts.
> > > >
> > > > Signed-off-by: Robert P. J. Day <rpjday@xxxxxxxxxxxxxx>
> > > >
> > > However, what's much worse is that this already has put series of
> > > constants which are part of the ABI under __KERNEL__. This is a
> > > very bad thing.
> >
> > i'm sure i'm just being dense but i have no clue what you're
> > referring to. AFAICT, that patch simply removed some redundant
> > preprocessor directives. am i missing something?

> I'm referring to the the patch that caused the redundant ifdefs,
> which was a recent change which among other things broke klibc.

ah, i didn't realize that the redundant ifdef's themselves were a
symptom of another problem.

rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/