Re: bug in kernel 2.6.21-rc1-git1: conventional floppy drive cannot be mounted without hanging up the whole system

[Benjamin LaHaise]

On Mon, Feb 26, 2007 at 07:51:19AM -0800, Linus Torvalds wrote:
> > Commit: 2ff2d3d74705d34ab71b21f54634fcf50d57bdd5
> > Author: Stephane Eranian <eranian@xxxxxxxxxx> Tue, 13 Feb 2007 13:26:22 +0100
> > 
> >     [PATCH] i386: add idle notifier
> 
> Interesting. It doesn't touch floppy at all, but it *does* seem to play 
> around with irq state. 

Side note: this patch adds several function calls (4), several additional 
L1 cache touches and a generally inefficient code path to *every single 
interrupt that exits from the idle poll*, not to mention the extra (useless, 
as it doesn't get used on 99.9% of deployed systems) function call and cache 
touches to every single interrupt.  Keep in mind that systems acting as 
routers will often be sitting in the idle loop when processing interrupts.  
At the very least this overhead (which is noticable on profiles) should be 
configurable.  I don't think that my 586 class embedded routers really need 
this crap to be going into the kernel.

		-ben
-- 
"Time is of no importance, Mr. President, only life is important."
Don't Email: <zyntrop@xxxxxxxxx>.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/