Re: [PATCH] libata: clear drvdata in ata_host_release()

From: Alan
Date: Sun Feb 25 2007 - 07:25:34 EST


On Sat, 24 Feb 2007 20:51:27 -0500
Jeff Garzik <jeff@xxxxxxxxxx> wrote:

> Tejun Heo wrote:
> > ata_host_release() uses drvdata to determine ata_host to release and
> > clearing drvdata in ->remove_one causes NULL pointer deference. Clear
> > drvdata only in ata_host_release() after all resources are freed.
> >
> > This bug was first analyzed by Alan Cox for pata_pcmcia.
> >
> > Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>
> > Cc: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
> > ---
> > Alan, this is the bug you talked about, right? I took the fix from
> > "[BUG] PATA_PCMCIA does not work" and expanded it. If this isn't the
> > one, please let me know. Thanks.
>
> Has a tester confirmed that this patch fixes the problem, and supercedes
> Alan's patch?

It doesn't appear to, instead it fixes further cases.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/