Re: typo in include/linux/irqflags.h ?

From: Nicholas Mc Guire
Date: Sat Feb 24 2007 - 08:40:34 EST


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sat, Feb 24, 2007 at 12:45:16PM +0100, Nicholas Mc Guire wrote:

Hi !

Seems like there was a cut&past error in include/linux/riqflags.h.


--- linux-2.6.20/include/linux/irqflags.h 2007-02-04 09:44:54.000000000 -0900
+++ linux-2.6.20xm/include/linux/irqflags.h 2008-01-27 20:29:26.000000000 -0900
@@ -91,6 +91,6 @@
})

#define irqs_disabled_flags(flags) raw_irqs_disabled_flags(flags)
-#endif /* CONFIG_X86 */
+#endif /* CONFIG_TRACE_IRQFLAGS_SUPPORT */

Just yet rid of the comment - you can see the corresponding #ifdef on
the screen without paging up or down so it seems pointless to have such
a comment - it just adds additional unnecessary clutter to the screen.

well not for people that only have one line on the braille-screen,
for it helps but it better be right or we get lost completly ;)

hofrat
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFF4DX6nU7rXZKfY2oRAg6zAJ4kK0c6T+fEXavRELt5vJnpLQxbYACfQhvR
bWg4oR0/6ng+1Cmlzwn7Igc=
=hQd0
-----END PGP SIGNATURE-----
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/