Re: [PATCH] update ctime and mtime for mmaped write

[Miklos Szeredi]

> > This flag is checked in msync() and __fput(), and if set, the file
> > times are updated and the flag is cleared
> 
> Why not also check inside vfs_getattr?

This is the minimum, that the standard asks for.

Note, your porposal would touch the times in vfs_getattr(), which
means, that the modification times would depend on the time of the
last stat() call, which is not really right, though it would still be
conforming.

It is much saner, if the modification time is always the time of the
last write() or msync().

Miklos
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/