Re: [PATCH 03/44 take 2] [UBI] user-space API header

From: Arnd Bergmann
Date: Sat Feb 17 2007 - 16:29:03 EST


On Saturday 17 February 2007 17:54, Artem Bityutskiy wrote:
> +struct ubi_mkvol_req {
> +       int32_t vol_id;
> +       int32_t alignment;
> +       int64_t bytes;
> +       int8_t vol_type;
> +       int8_t padding[9];
> +       int16_t name_len;
> +       __user const char *name;
> +} __attribute__ ((packed));

This structure is not suitable for an ioctl call, because it has
incompatible layout between 32 and 64 bit processes. The easiest
fix for this would be to change the 'name' field to an array
instead of a pointer.

Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/