Re: [patches] [PATCH 2.6.21 review I] [21/25] x86_64: a memcpy that tries to reduce cache pressure
From: Andi Kleen
Date: Mon Feb 12 2007 - 05:26:11 EST
> This looks a little strange to me:
> - the first 128 bytes are still going through the cache
> - up to 192 bytes past the copied area are being marked non-temporal, while
> there's nothing known about that area
Yes that seems quite bogus.
> - sfence seems questionable here, I would have thought this should be lfence,
> or perhaps even none at all
Agreed -- it's not needed.
I think i also objected earlier to the jump table which is likely slower.
Will drop for now.
-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/