[PATCH] slip: Replace kmalloc() + memset() pairs with theappropriate kzalloc() calls

From: joe jin
Date: Tue Jan 16 2007 - 01:44:16 EST


This patch replace kmalloc() + memset() pairs with the appropriate
kzalloc().

Signed-off-by: Joe Jin <joe.jin@xxxxxxxxxx>

--- drivers/net/slip.c.orig 2007-01-16 14:21:52.000000000 +0800
+++ drivers/net/slip.c 2007-01-16 14:23:07.000000000 +0800
@@ -1343,15 +1343,12 @@
printk(KERN_INFO "SLIP linefill/keepalive option.\n");
#endif

- slip_devs = kmalloc(sizeof(struct net_device *)*slip_maxdev,
GFP_KERNEL);
+ slip_devs = kzalloc(sizeof(struct net_device *)*slip_maxdev,
GFP_KERNEL);
if (!slip_devs) {
printk(KERN_ERR "SLIP: Can't allocate slip devices array! Uaargh! (-
> No SLIP available)\n");
return -ENOMEM;
}

- /* Clear the pointer array, we allocate devices when we need them */
- memset(slip_devs, 0, sizeof(struct net_device *)*slip_maxdev);
-
/* Fill in our line protocol discipline, and register it */
if ((status = tty_register_ldisc(N_SLIP, &sl_ldisc)) != 0) {
printk(KERN_ERR "SLIP: can't register line discipline (err = %d)\n",
status);



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/