Re: [PATCH 18/19] ide: add ide_use_fast_pio() helper

[Bartlomiej Zolnierkiewicz]

On 1/12/07, Alan <alan@xxxxxxxxxxxxxxxxxxx> wrote:
> >               if(strstr(id->model, "Integrated Technology Express")) {
> >                       /* In raid mode the ident block is slightly buggy
> >                          We need to set the bits so that the IDE layer knows
> >                          LBA28. LBA48 and DMA ar valid */
> >                       id->capability |= 3;            /* LBA28, DMA */
> >
> > and we are better off using generic helper if we can
> > (which may later allow us to use generic tuning code).
>
> IT8212 in smart mode has no tuning at all, the real modes are hidden by
> the controller. Some firmware versions don't seem to be like being fed
> set features commands either hence the total lack of tuning.

[ The discussed "ide: add ide_use_fast_pio() helper" patch doesn't fix it
 but it doesn't break anything either (it doesn't change the current
behavior). ]

It seems that it821x_tune_chipset() is buggy since it sends SET FEATURES
command even when in smart mode.  Shouldn't there be "don't tune" flag
in it812x_fixups() to tell it821x_tune_chipset() to not send SET FEATURES
commands?

Bart
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/