Re: [patch 2.6.20-rc3] rtc-sh correctly reports rtc_wkalrm.enabled

[Jamie Lenehan]

On Fri, Jan 05, 2007 at 08:55:05PM -0800, David Brownell wrote:
[...]
> An audit of the RTC driver treatment of the "enabled" flag turned
> up a handful of clear bugs; most drivers handle it the same now

Yeah, I missed the existing of the enabled flag when I added alarm
support to the driver. Your patch is fine.

> This driver has another issue:  sh_rtc_set_alarm() ignores the
> "enabled" flag, rather than using it to tell whether the alarm
> should be enabled on exit from that routine.  One at a time.  :)

I'll can take care of this.

-- 
 Jamie Lenehan <lenehan@xxxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/