Re: [PATCH 4/4] Add MMC Password Protection (lock/unlock) supportV9: mmc_sysfs.diff

[Pierre Ossman]

Anderson Briglia wrote:
>> There's also no handling for an invalid string written to the sysfs node.
>>     
>
> Is this really needed? I thought the function just ignored other values sent to itself that were not handled.
>
>   

Well, returning an error on invalid data is the right<tm> thing to do.
And the warning about mmc_key is caused by this lack of error handling.

Rgds

-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/