Re: [PATCH] Remove useless FIND_FIRST_BIT() macro from cardbus.c.

From: Randy Dunlap
Date: Mon Jan 08 2007 - 21:46:50 EST


On Mon, 8 Jan 2007 20:20:28 -0500 (EST) Robert P. J. Day wrote:

>
> Delete the definition of the unused FIND_FIRST_BIT() macro.
>
> Signed-off-by: Robert P. J. Day <rpjday@xxxxxxxxxxxxxx>
>
> ---
>
> this macro seems safely deletable, given that there is no other
> reference to that macro anywhere in the entire source tree and,
> besides, one should use find_first_bit() anyway.
>
> it's not clear who the official maintainer is for this subsystem
> these days.

I believe that it should go to (from MAINTAINERS):

PCMCIA SUBSYSTEM
P: Linux PCMCIA Team
L: linux-pcmcia@xxxxxxxxxxxxxxxxxxx
L: http://lists.infradead.org/mailman/listinfo/linux-pcmcia
T: git kernel.org:/pub/scm/linux/kernel/git/brodo/pcmcia-2.6.git
S: Maintained

> diff --git a/drivers/pcmcia/cardbus.c b/drivers/pcmcia/cardbus.c
> index 2d7effe..a1bd763 100644
> --- a/drivers/pcmcia/cardbus.c
> +++ b/drivers/pcmcia/cardbus.c
> @@ -40,8 +40,6 @@
>
> /*====================================================================*/
>
> -#define FIND_FIRST_BIT(n) ((n) - ((n) & ((n)-1)))
> -
> /* Offsets in the Expansion ROM Image Header */
> #define ROM_SIGNATURE 0x0000 /* 2 bytes */
> #define ROM_DATA_PTR 0x0018 /* 2 bytes */
> -

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/