Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update

From: Oleg Nesterov
Date: Sun Jan 07 2007 - 09:22:08 EST


On 01/07, Oleg Nesterov wrote:
>
> Thoughts?

How about:

CPU_DEAD does nothing. After __cpu_disable() cwq->thread runs on
all CPUs and becomes idle when it flushes cwq->worklist: nobody
will add work_struct on that list.

CPU_UP:
if (!cwq->thread)
create_workqueue_thread();
else
set_cpus_allowed(newcpu);

flush_workqueue:
for_each_possible_cpu() // NOT online!
if (cwq->thread)
flush_cpu_workqueue()

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/