Re: [PATCH -mm 8/8] user ns: implement user ns unshare

From: Serge E. Hallyn
Date: Thu Jan 04 2007 - 23:35:52 EST


Quoting Valdis.Kletnieks@xxxxxx (Valdis.Kletnieks@xxxxxx):
> On Thu, 04 Jan 2007 16:52:53 CST, "Serge E. Hallyn" said:
> > Quoting Valdis.Kletnieks@xxxxxx (Valdis.Kletnieks@xxxxxx):
> > > On Thu, 04 Jan 2007 19:07:00 GMT, Frederik Deweerdt said:
> > > > > int err = 0;
> > > > ^^^^^^^^^^^^
> > > > The "= 0" is superfluous here.
> > >
> > > Umm? bss gets cleared automagically, but when did we start auto-zeroing
> > > the stack?
> >
> > No, no, that's what i thought he meant at first too, but I actually
> > manually set err on all paths anyway :)
>
> Oh. So it's *really* just "superfluous until somebody changes the code"...

True.

-serge
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/