Re: [PATCH] remove 556 unneeded #includes of sched.h

From: Randy Dunlap
Date: Thu Dec 28 2006 - 16:00:34 EST


On Thu, 28 Dec 2006 12:46:44 -0800 Andrew Morton wrote:

> On Thu, 28 Dec 2006 21:27:40 +0100 (CET)
> Tim Schmielau <tim@xxxxxxxxxxxxxxxxxxxxxx> wrote:
>
> > After Al Viro (finally) succeeded in removing the sched.h #include in
> > module.h recently, it makes sense again to remove other superfluous
> > sched.h includes.
>
> Why are they "superfluous"? Because those compilation
> units pick up sched.h indirectly, via other includes?

I'm half done with a patch to remove includes of smp_lock.h.
For the files that I have patched, I checked each source file
for all interfaces in smp_lock.h to verify that none of them
are used, so the #include is just waste.

> If so, is that a thing we want to do?

Nope.

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/