Re: [FSAIO][PATCH 7/8] Filesystem AIO read

[Jan Engelhardt]

On Dec 28 2006 11:57, Christoph Hellwig wrote:
>
>> +
>> +		if ((error = __lock_page(page, current->io_wait))) {
>> +			goto readpage_error;
>> +		}
>
>This should  be
>
>		error = __lock_page(page, current->io_wait);
>		if (error)
>			goto readpage_error;

That's effectively the same. Essentially a style thing, and I see if((err =
xyz)) not being uncommon in the kernel tree.


	-`J'
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/