Re: [patch] block: remove BKL dependency from drivers/block/loop.c

From: Ingo Molnar
Date: Wed Dec 27 2006 - 10:51:08 EST



* Ingo Molnar <mingo@xxxxxxx> wrote:

> Subject: [patch] block: remove BKL dependency from drivers/block/loop.c
> From: Ingo Molnar <mingo@xxxxxxx>
>
> the block loopback device is protected by lo->lo_ctl_mutex and it does
> not need to hold the BKL anywhere. Convert its ioctl to unlocked_ioctl
> and remove the BKL acquire/release from its compat_ioctl.

hm, i must have messed up this bit:

> +static long lo_ioctl(struct file * file, unsigned int cmd, unsigned long arg)
> {
> + struct inode *inode = file->f_path.dentry->d_inode;
> struct loop_device *lo = inode->i_bdev->bd_disk->private_data;

because it now crashes there ... so forget this patch for now.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/