Re: [PATCH] Sanely size hash tables when using large base pages.

From: Fengguang Wu
Date: Tue Dec 26 2006 - 03:13:57 EST


Hi Paul,

On Tue, Dec 26, 2006 at 03:16:52PM +0900, Paul Mundt wrote:
> pidhash_shift = max(4, fls(megabytes * 4));
> pidhash_shift = min(12, pidhash_shift);
> pidhash_size = 1 << pidhash_shift;
>
> + size = pidhash_size * sizeof(struct hlist_head);
> + if (unlikely(size < PAGE_SIZE)) {
> + size = PAGE_SIZE;
> + pidhash_size = size / sizeof(struct hlist_head);
> + pidhash_shift = 0;

But pidhash_shift is not the order of page ;-)

Regards,
Wu
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/