Re: [RFC][PATCH -mm 3/5] add interface for netconsole using sysfs

[Keiichi KII]

Thank you for your replies and reviews.

I will follow your advices.

> >  static LIST_HEAD(target_list);
> >  
> >  static DEFINE_SPINLOCK(target_list_lock);
> >  
> > +static ssize_t show_local_ip(struct netconsole_target *nt, char *buf)
> > +{
> > +	return sprintf(buf, "%d.%d.%d.%d\n", HIPQUAD(nt->np.local_ip));
>
> I don't understand the use of HIPQUAD() here instead of
> NIPQUAD().  Explain?
>
> Also, NIPQUAD_FMT (in kernel.h) uses "%u.%u.%u.%u".
> This should probably be the same.
> Or just use:	NIPQUAD_FMT "\n"

IP address is stored in the form of host byte order in netpoll structure.
So, You can't use NIPQUAD to follow the current implementation of netpoll.

--
Keiichi KII
NEC Corporation OSS Promotion Center
E-mail: k-keiichi@xxxxxxxxxxxxx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/