[PATCH] module: fix mod_sysfs_setup() return value

From: Akinobu Mita
Date: Mon Dec 25 2006 - 03:16:26 EST


mod_sysfs_setup() doesn't return error when kobject_add_dir() failed.

Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>

---
kernel/module.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

Index: 2.6-mm/kernel/module.c
===================================================================
--- 2.6-mm.orig/kernel/module.c
+++ 2.6-mm/kernel/module.c
@@ -1132,8 +1132,10 @@ static int mod_sysfs_setup(struct module
goto out;

mod->drivers_dir = kobject_add_dir(&mod->mkobj.kobj, "drivers");
- if (!mod->drivers_dir)
+ if (!mod->drivers_dir) {
+ err = -ENOMEM;
goto out_unreg;
+ }

err = module_param_sysfs_setup(mod, kparam, num_params);
if (err)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/