Re: [PATCH 2/10] cxgb3 - main source file

From: Arjan van de Ven
Date: Thu Dec 21 2006 - 03:16:49 EST



> They are used to parameter the HW:
> register access,

ethtool supports that, so shouldn't be an ioctl for sure

> configuration of queue sets, on board memory
> configuration,

I'm sure ethtool can do that too

> firmware load, etc ...

and for this we have request_firmware() interface.

adding device specific ioctl that duplicate functionality that exists or
should exist in a generic way isn't really acceptable for 2.6 kernels
anymore....



--
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/