Re: [-mm patch] drivers/ide/pci/tc86c001.c: make a function static

From: Sergei Shtylyov
Date: Sun Dec 17 2006 - 13:07:43 EST


Hello.

Adrian Bunk wrote:

+toshiba-tc86c001-ide-driver-take-2.patch

This patch makes the needlessly global init_hwif_tc86c001() static.

Duh, I hoped tha this driver may get into 2.6.20-rc1 and finally overlooked this. Sigh, uou won't believe how much time this driver rewrite spent in an unfinished state in my internal tree... :-/

Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>

---

BTW:
I'm not sure whether it'd be a good idea to include such a driver for the legacy IDE subsystem without a libata based driver for the same hardware.

Well, I'd agree with Alan here. Don't expect me to convert this to libata in the foreseeable future... I'd like to join the folks hacking on libata but this certainly won't happen soon (if at all)...

WBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/