Re: [PATCH] pata_via: Cable detect error

From: Jeff Garzik
Date: Sat Dec 16 2006 - 11:08:48 EST


Alan wrote:
The UDMA66 VIA hardware has no controller side cable detect bits we can
use. This patch minimally fixes the problem by reporting unknown in this
case and using drive side detection.

The old drivers/ide code does some additional tricks but those aren't
appropriate now we are in -rc.

Without this update UDMA66 via controllers run slowly. They don't fail so
it's a borderline call whether this is -rc material or not.

Signed-off-by: Alan Cox <alan@xxxxxxxxxx>

I think it's #upstream-fixes material (-rc material), and applied as such.

Especially considering that libata pata_* drivers are not the primary drivers, I think it's best to forward this type of stuff, especially as it is indeed IMO a fix worth having.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/