Re: [PATCH] libata: don't initialize sg in ata_exec_internal() ifDMA_NONE
From: Jeff Garzik
Date: Mon Dec 11 2006 - 09:34:33 EST
Arnd Bergmann wrote:
On Monday 11 December 2006 15:02, Tejun Heo wrote:
{
struct scatterlist sg;
+ unsigned int n_elem = 0;
- sg_init_one(&sg, buf, buflen);
+ if (dma_dir != DMA_NONE) {
+ WARN_ON(!buf);
+ sg_init_one(&sg, buf, buflen);
+ n_elem++;
+ }
Ok, looks good as well. I still think we should have the WARN_ON()
in sg_set_buf(), but I can send a separate patch for that to linux-mm.
Please CC me and linux-ide on all libata patches (certainly akpm as
well). Andrew picks up most of the libata changes automatically via git
from my libata-dev.git#ALL.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/