Re: [PATCH] freezer.h uses task_struct fields

[Andrew Morton]

On Fri, 08 Dec 2006 08:31:11 -0600
Dave Kleikamp <shaggy@xxxxxxxxxxxxxxxx> wrote:

> > include/linux/freezer.h: In function 'frozen_process':
> > include/linux/freezer.h:55: error: dereferencing pointer to incomplete type
> > include/linux/freezer.h:55: error: dereferencing pointer to incomplete type
> > include/linux/freezer.h:55: error: 'PF_FREEZE' undeclared (first use in this function)
> > include/linux/freezer.h:55: error: 'PF_FROZEN' undeclared (first use in this function)
> > fs/jfs/jfs_txnmgr.c: In function 'freezing':
> > include/linux/freezer.h:18: warning: control reaches end of non-void function
> > make[2]: *** [fs/jfs/jfs_txnmgr.o] Error 1
> 
> Defining CONFIG_SMP or CONFIG_PREEMPT masks this problem (at least in
> jfs), since smp_lock.h will include sched.h when CONFIG_LOCK_KERNEL is
> defined, and smp_lock.h happens to be included by jfs_txngmr.c before
> freezer.h.
> 
> > 
> > Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> 
> Acked-by: Dave Kleikamp <shaggy@xxxxxxxxxxxxxxxxxx>

OK, thanks guys.  This is the sort of patch which I like to put
through a decent round of cross-compilation testing, so it's unlikely
to appear in mainline for 2-3 days.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/