Re: [PATCH -mm 3/4][AIO] - AIO completion signal notification

From: Sébastien Dugué
Date: Thu Nov 23 2006 - 05:28:14 EST


On Thu, 23 Nov 2006 02:14:37 -0800
Andrew Morton <akpm@xxxxxxxx> wrote:

[snip]

> Look:
>
> > + notify->target = target;
> > +
> > + if (notify->notify == (SIGEV_SIGNAL|SIGEV_THREAD_ID)) {
> > + /*
> > + * This reference will be dropped in really_put_req() when
> > + * we're done with the request.
> > + */
> > + get_task_struct(target);
>
> If that test fails, we've saved a pointer to the task_struct without having
> taken a refreence on it.
>

Aggreed, just wanted to make sure.

Thanks,

Sébastien.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/