Re: [Patch -mm 2/2] driver core: Introduce device_move(): move adevice

[Alan Stern]

On Wed, 22 Nov 2006, Cornelia Huck wrote:

> On Wed, 22 Nov 2006 10:32:47 -0500 (EST),
> Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:

> > I don't see any protection against new_parent being removed while dev is
> > being transferred under it.  Are you relying on the caller to make sure
> > this never happens?
> 
> Is there any mechanism in the driver core to avoid such races? The only
> locking I can see are klists and dev->sem (which only protects
> probing). AFAICS, the caller needs to ensure consistency anyway (like
> with the subchannel mutex we introduced in s390 to ensure device
> register and unregister cannot be called concurrently).

Generally the driver core does rely on callers to handle these things.
I just wanted to make sure you were aware of the issue.

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/