Re: [PATCH] add return value checking of get_user() inset_vesa_blanking()

[Yoichi Yuasa]

On Tue, 21 Nov 2006 17:31:15 -0800
Andrew Morton <akpm@xxxxxxxx> wrote:

> On Tue, 21 Nov 2006 14:15:28 +0900
> Yoichi Yuasa <yoichi_yuasa@xxxxxxxxxxxxxx> wrote:
> 
> > Hi,
> > 
> > This patch has added return value checking of get_user() in set_vesa_blanking().
> > 
> > Yoichi
> > 
> > Signed-off-by: Yoichi Yuasa <yoichi_yuasa@xxxxxxxxxxxxxx>
> >  
> > diff -pruN -X generic/Documentation/dontdiff generic-orig/drivers/char/vt.c generic/drivers/char/vt.c
> > --- generic-orig/drivers/char/vt.c	2006-11-21 10:23:39.409667250 +0900
> > +++ generic/drivers/char/vt.c	2006-11-21 10:11:48.037209250 +0900
> > @@ -3318,9 +3318,10 @@ postcore_initcall(vtconsole_class_init);
> >  
> >  static void set_vesa_blanking(char __user *p)
> >  {
> > -    unsigned int mode;
> > -    get_user(mode, p + 1);
> > -    vesa_blank_mode = (mode < 4) ? mode : 0;
> > +	unsigned int mode;
> > +
> > +	if (!get_user(mode, p + 1))
> > +		vesa_blank_mode = (mode < 4) ? mode : 0;
> >  }
> >  
> >  void do_blank_screen(int entering_gfx)
> 
> How about we go all the way?

It's good for us.

Thanks,

Yoichi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/