Re: [PATCH] ieee1394: nodemgr: fix deadlock in shutdown

From: Alan Stern
Date: Tue Nov 21 2006 - 21:03:22 EST


On Tue, 21 Nov 2006, Stefan Richter wrote:

> There is now a /sys/bus/ieee1394/drivers/ieee1394, whose "bind" and
> "unbind" attributes are not welcome. Is there a way to disable them?

You can always prevent "bind" from operating by returning an error code
from the driver's probe routine (although it's not clear why you would
want to do that). I don't think there's any way to make the "unbind"
attribute stop working.

You could violate the layering and remove the attribute files directly.
But that would be a race; there would remain a brief interval between the
time the files were created and the time you removed them.

Lastly, you could remove source of your deadlock by having the unbind
routine for the new driver delete all the child device structures. In
fact, just to make things more symmetric and logical you could have the
probe routine create those child devices in the first place!

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/