Re: [PATCH]: first proposal for pci resume quirk interface

From: Carl-Daniel Hailfinger
Date: Tue Nov 21 2006 - 09:57:55 EST


Alan wrote:
> --- linux.vanilla-2.6.19-rc5-mm1/arch/i386/pci/fixup.c 2006-11-10 10:38:25.000000000 +0000
> +++ linux-2.6.19-rc5-mm1/arch/i386/pci/fixup.c 2006-11-14 15:13:03.000000000 +0000
> @@ -117,7 +117,7 @@
> #define VIA_8363_KL133_REVISION_ID 0x81
> #define VIA_8363_KM133_REVISION_ID 0x84
>
> -static void __devinit pci_fixup_via_northbridge_bug(struct pci_dev *d)
> +static void pci_fixup_via_northbridge_bug(struct pci_dev *d)
> {
> u8 v;
> u8 revision;

I sent a similar patch about one year ago and it was rejected back then.
Any reasons why fixups on resume suddenly are desirable?
(I agree with the patch wholehartedly and will test it ASAP on my
Samsung P35 laptop which needs the asus_hides_smbus quirk.)

Regards,
Carl-Daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/