Re: [stable] [PATCH 46/61] fix Intel RNG detection

[Jan Beulich]

>>> Chris Wright <chrisw@xxxxxxxxxxxx> 21.11.06 03:21 >>>
>* Dave Jones (davej@xxxxxxxxxx) wrote:
>> Since I pushed an update to our Fedora users based on 2.6.18.2, a few people
>> have reported they no longer have their RNG's detected.
>> Here's one report: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215144 
>
>Hmm, I wonder if the report is valid?  Jan's patch would have the correct
>side effect of disabling false positives (for RNG identification).
>Be good to check that it actually used to work.

Indeed, that is quite significant to know here.

>Having said that, Jan the datasheet recommendation is looser than your
>implementation.  It only recommends checking for manufacturer code,
>you check device code as well.  Do you know of any scenarios where that
>would matter (I can't conceive of any)?

Since Intel doesn't list any other device codes, I suppose there are none.
But of course, it's not entirely impossible that there are others, but I
wouldn't want to relax the already weak check; I'd rather want to add
other device codes if we have proof that these are valid.

Jan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/