Re: Siemens sx1: merge framebuffer support

From: Vladimir
Date: Tue Nov 21 2006 - 02:19:05 EST


2006/11/20, Tony Lindgren <tony@xxxxxxxxxxx>:
* Pavel Machek <pavel@xxxxxx> [061118 18:16]:
> From: Vladimir Ananiev <vovan888@xxxxxxxxx>
>
> Framebuffer support for Siemens SX1; this is second big patch. (Third
> one will be mixer/sound support). Support is simple / pretty minimal,
> but seems to work okay (and is somehow important for a cell phone :-).

Pushed to linux-omap. I guess you're planning to send the missing
Kconfig + Makefile patch for this?

Also, it would be better to use omap_mcbsp_xmit_word() or
omap_mcsbsp_spi_master_xmit_word_poll() instead of OMAP_MCBSP_WRITE as
it does not do any checking that it worked. The aic23 and tsc2101
audio in linux-omap tree in general has the same problem.

Regards,

Tony


Hmm. McBSP3 in SX1 is used in "GPIO mode". The only line used is CLKX,
so I think OMAP_MCBSP_WRITE would be enough. Am I wrong ?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/