Re: [PATCH] backlight: do not power off backlight when unregistering

[Henrique de Moraes Holschuh]

On Mon, 20 Nov 2006, James Simmons wrote:
> > The following in-tree (latest linux-2.6 git tree) drivers are desktop/laptop
> > devices and likely do not want the "dim and power off backlight on
> > backlight_device_unregister" behavior:
> > 
> > drivers/video/aty/*
> > drivers/video/riva/fbdev.c
> > drivers/video/nvidia/nv_backlight.c
> > drivers/misc/msi-laptop.c
> 
> ...
>  
> > I have CC'ed the relevant people (please forgive me any ommissions) for the
> > drivers listed above, so they can chime in if their driver should retain the
> > "dim and power off backlight on backlight_device_unregister" behaviour.
> 
> Hm. In the case of some drivers the hardware state on x86 is set back to 
> text mode in some cases. So do we in that case dim the backlight?

I would very much *hate* that happening on any x86 box of mine.  I won't
presume I understand enough of the usage pattern on weird devices, and it
would make some sense to power off the display if you are removing the
*only* way to talk to the video device (but I still think this is naively
assuming the local admin don't want to just leave the display as-is).

But as you said yourself, in regular desktop/laptops (at least x86 ones)
textmode is there, and works just fine, so killing the display on module
removal is wrong IMO.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/