Re: [PATCH 12/19] CacheFiles: Permit a process's create SID to beoverridden

[James Morris]

On Mon, 20 Nov 2006, Stephen Smalley wrote:

> > The ability to set this needs to be mediated via MAC policy.
> > 
> > See selinux_setprocattr()
> 
> That's different - selinux_set_fscreate_secid() is for internal use by a
> kernel module that wishes to temporarily assume a particular fscreate
> SID, whereas selinux_setprocattr() handles userspace writes
> to /proc/self/attr nodes.  Imposing a permission check here makes no
> sense.

Well, the hook is exported generally to the kernel, so we need to 
ensure that it is documented with a big warning.  The name of the hook 
should perhaps make it more obvious,  like set_internal_ or so.



- James
-- 
James Morris
<jmorris@xxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/