Re: [PATCH 3/4] atl1: Main C file for Attansic L1 driver

[Stephen Hemminger]

On Mon, 20 Nov 2006 14:35:10 -0500
Jeff Garzik <jeff@xxxxxxxxxx> wrote:

> Stephen Hemminger wrote:
> > Using common MII code is good, but one problem with the existing MII code is that
> > it doesn't work when device is down. This makes it impossible to set speed/duplex
> > before device comes up.
> 
> 
> That's not true at all.  drivers/net/mii.c uses caller-provided locking 
> in all cases, and there is nothing that prevents the common code from 
> being called when the interface is down.
> 
> You are probably thinking about all the netif_running() checks found in 
> the drivers, particularly in the ->begin() hook.
> 
> 	Jeff
> 
> 

Yeah it is a driver specific thing. All users of mii seem to block changes so
I thought it was in base code.


-- 
Stephen Hemminger <shemminger@xxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/