Re: [PATCH 3/4] atl1: Main C file for Attansic L1 driver

[Stephen Hemminger]

On Mon, 20 Nov 2006 13:21:59 +0100
Arnd Bergmann <arnd@xxxxxxxx> wrote:

> On Monday 20 November 2006 07:12, Chris Snook wrote:
> > > 
> > > Any reason why you can't use generic_mii_ioctl?
> > 
> > I decided to mostly leave this code alone, in the hope that we could 
> > just rip out MII support entirely and nobody would mind. ÂWhat do you think?
> > 
> 
> Normally, I think you should just implement mdio_read/mdio_write functions
> and then use all the helpers from drivers/net/mii.c to implement mii_ioctl
> and other functions like ethtool_gset.
> 
> 	Arnd <><
> 

Using common MII code is good, but one problem with the existing MII code is that
it doesn't work when device is down. This makes it impossible to set speed/duplex
before device comes up.

-- 
Stephen Hemminger <shemminger@xxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/