Re: [PATCH 0/4] atl1: Revised Attansic L1 ethernet driver

From: Alan
Date: Mon Nov 20 2006 - 04:42:31 EST


> > Be careful with :1 bitfields when working with hardware - the compiler
> > has more than one choice about how to pack them.
>
> Lacking a spec, I'm not entirely sure what the original intent was, so
> we're stuck with testing. Is there a specific disambiguation technique
> you recommend?

Assuming the driver works on x86 then you know how the bits are laid out.
You may find later you need to put in ifdefs for bitfield endian-ness as
we do in things like include/linux/ip.h

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/