Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoitype IRQ handlers

From: Sergei Shtylyov
Date: Sun Nov 19 2006 - 15:30:43 EST


Hello.

Ingo Molnar wrote:

What do you need an ack() for on fasteoi ? On all fasteoi controllers I have, ack is implicit by obtaining the vector number and all there is is an eoi...

it's a compatibility hack only. Threaded handlers are a different type of flow, but often the fasteoi handler is not changed to the threaded handler so i changed it to be a threaded handler too.

The fasteoi flow seem to only had been used for x86 IOAPIC in the RT patch only *before* PPC took to using them in the mainline...

threaded handlers need a mask() + an ack(), because that's the correct

Not all of them. This could be customized on type-by-type basis. I.e. we could call eoi() instead of ack() for fasteoi chips without having to resort to the duplicated ack/eoi handlers.

model to map them to kernel threads - threaded handlers can be delayed for a long time if something higher-prio is preempting them.

Ingo

WBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/