Re: [rfc patch] Re: sched: incorrect argument used in task_hot()

From: Ingo Molnar
Date: Sat Nov 18 2006 - 02:29:42 EST



* Chen, Kenneth W <kenneth.w.chen@xxxxxxxxx> wrote:

> - if (sd->nr_balance_failed > sd->cache_nice_tries)
> + if (sd->nr_balance_failed > sd->cache_nice_tries) {
> + #ifdef CONFIG_SCHEDSTATS
> + if (task_hot(p, rq->most_recent_timestamp, sd))
> + schedstat_inc(sd, lb_hot_gained[idle]);
> + #endif
> return 1;
> + }

minor nit: preprocessor directives should be aligned to the first
column.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/