Re: [RFC 1/7] Remove declaration of sighand_cachep from slab.h

From: Stephen Rothwell
Date: Sat Nov 18 2006 - 01:28:10 EST


On Fri, 17 Nov 2006 21:43:47 -0800 (PST) Christoph Lameter <clameter@xxxxxxx> wrote:
>
> Remove declaration of sighand_cachep from slab.h
>
> The sighand cache is only used in fs/exec.c and kernel/fork.c. It is defined
> in kernel/fork.c but also used in fs/exec.c. So add an extern declaration to
> fs/exec.c and remove the definition from slab.h.
>
> Signed-off-by: Christoph Lameter <clameter@xxxxxxx>
>
> Index: linux-2.6.19-rc5-mm2/fs/exec.c
> ===================================================================
> --- linux-2.6.19-rc5-mm2.orig/fs/exec.c 2006-11-15 16:47:59.065579813 -0600
> +++ linux-2.6.19-rc5-mm2/fs/exec.c 2006-11-17 23:03:46.049603927 -0600
> @@ -62,6 +62,8 @@ int core_uses_pid;
> char core_pattern[128] = "core";
> int suid_dumpable = 0;
>
> +extern kmem_cache_t *sighand_cachep;

Is there no suitable header file to put this in?

--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature