Re: [PATCH 1/10] cxgb3 - main header files

[Roland Dreier]

 > > +#define MDIO_LOCK(adapter) down(&(adapter)->mdio_lock)
 > > +#define MDIO_UNLOCK(adapter) up(&(adapter)->mdio_lock)
 > 
 > Please don't wrap locks

Plus these should probably be mutexes, not semaphores.

 > > +int t3_offload_tx(struct t3cdev *tdev, struct sk_buff *skb);
 > 
 > What kind of offload?  You remember TOE was rejected.

But we're OK with RDMA over TCP (iWARP) I think...

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/